-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buildkite: Cleanup env #2146
Buildkite: Cleanup env #2146
Conversation
3b267c1
to
9833756
Compare
9833756
to
4a43771
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r1.
Reviewable status: 6 of 8 files reviewed, 2 unresolved discussions (waiting on @kormat and @worxli)
.buildkite/clean_env.sh, line 6 at r1 (raw file):
[ -n "$cntrs" ] && { echo "Remove left over containers: $cntrs"; docker rm -f "$cntrs"; } echo "Try to remove left over networks"
Why try? Can it fail?
.buildkite/pipeline.sh, line 14 at r1 (raw file):
# begin the pipeline.yml file ".buildkite/common.sh"
Add a comment to note that common.sh
sets $BASE
, so it can't be used here yet.
1440d7c
to
bc84b51
Compare
bc84b51
to
0fe20be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 7 files reviewed, 2 unresolved discussions (waiting on @kormat)
.buildkite/clean_env.sh, line 6 at r1 (raw file):
Previously, kormat (Stephen Shirley) wrote…
Why try? Can it fail?
No, but there may be none.
.buildkite/pipeline.sh, line 14 at r1 (raw file):
Previously, kormat (Stephen Shirley) wrote…
Add a comment to note that
common.sh
sets$BASE
, so it can't be used here yet.
Other way round.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
Fix the service name of SCIOND. This caused the acceptance tests to fail.
Also add a cleanup step to the buildkite pipeline.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)