Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildkite: Cleanup env #2146

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Buildkite: Cleanup env #2146

merged 2 commits into from
Nov 21, 2018

Conversation

worxli
Copy link
Contributor

@worxli worxli commented Nov 20, 2018

Fix the service name of SCIOND. This caused the acceptance tests to fail.
Also add a cleanup step to the buildkite pipeline.

This change is Reviewable

@worxli worxli force-pushed the fix-acceptance branch 3 times, most recently from 3b267c1 to 9833756 Compare November 21, 2018 08:16
@worxli worxli changed the title Fix sciond service name Buildkite: Cleanup env Nov 21, 2018
Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1.
Reviewable status: 6 of 8 files reviewed, 2 unresolved discussions (waiting on @kormat and @worxli)


.buildkite/clean_env.sh, line 6 at r1 (raw file):

[ -n "$cntrs" ] && { echo "Remove left over containers: $cntrs"; docker rm -f "$cntrs"; }

echo "Try to remove left over networks"

Why try? Can it fail?


.buildkite/pipeline.sh, line 14 at r1 (raw file):

# begin the pipeline.yml file
".buildkite/common.sh"

Add a comment to note that common.sh sets $BASE, so it can't be used here yet.

@worxli worxli force-pushed the fix-acceptance branch 3 times, most recently from 1440d7c to bc84b51 Compare November 21, 2018 11:57
Copy link
Contributor Author

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 7 files reviewed, 2 unresolved discussions (waiting on @kormat)


.buildkite/clean_env.sh, line 6 at r1 (raw file):

Previously, kormat (Stephen Shirley) wrote…

Why try? Can it fail?

No, but there may be none.


.buildkite/pipeline.sh, line 14 at r1 (raw file):

Previously, kormat (Stephen Shirley) wrote…

Add a comment to note that common.sh sets $BASE, so it can't be used here yet.

Other way round.

Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@worxli worxli merged commit 5f3d20c into scionproto:master Nov 21, 2018
@worxli worxli deleted the fix-acceptance branch November 21, 2018 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants